feat: Add new useUsersBasicInfo from latest update in SDK #71
Draft
GuiLeme wants to merge 2 commits intobigbluebutton:v0.0.xfrom
Draft
feat: Add new useUsersBasicInfo from latest update in SDK #71GuiLeme wants to merge 2 commits intobigbluebutton:v0.0.xfrom
GuiLeme wants to merge 2 commits intobigbluebutton:v0.0.xfrom
Conversation
Collaborator
|
IMO it doesn´t make sense to show "and 1 other", in this case it would be easier to just show the name of this user. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
From SDK@v0.0.92 onwards, we added some information and sorting to
useUsersBasicInfohook, and with that new addition, we can remove the previous custom-subscription we had, and replace it so that issue #57 would even be resolved.This PR also re-creates the way we show list of users yet to be picked
Closes Issue(s)
Closes #57
More
Heads up: with this new addition, new versions of pick-random-user will only work with BBB's that contain SDKs with versions greater than v0.0.92 (otherwise, bbb-web will block the plugin from loading up);
Here is the new way we show the horizontal: