-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Minimal FontSize support
#22614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ickshonpe
wants to merge
12
commits into
bevyengine:main
Choose a base branch
from
ickshonpe:font-size
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Minimal FontSize support
#22614
+445
−239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the new `RemSize` resource.
Implemented Mul<f32> for FontSize
Member
|
Wondering if this PR supersedes #9524? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Text
Rendering and layout for characters
A-UI
Graphical user interfaces, styles, layouts, and widgets
C-Feature
A new feature, making something new possible
D-Modest
A "normal" level of difficulty; suitable for simple features or challenging fixes
M-Deliberate-Rendering-Change
An intentional change to how tests and examples are rendered
M-Release-Note
Work that should be called out in the blog due to impact
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add support for responsive font sizes supporting rem and viewport units.
Solution
The
font_sizefield ofTextFontis now aFontSize.New
FontSizeenum:FontSizehas anevalmethod that takes viewport and rem values and resolves the actual logical font size.The text implementations have to pass in the viewport and rem values to
TextPipeline'supdate_bufferandcreate_text_measurefunctions, so the font sizes can be evaluated.Text2duses the size of the primary window to resolve viewport values (orVec2::splat(1000)if no primary window found).There are some limitations because we don't have any sort of font style inheritance yet:
FontSizevalues are only reevaluated on changes toTextFontatm, not on changes to the viewport and rem base values.Remunits aren't really rem units, and just based on the value of a resource.Testing
The examples should work, but bound to be mistakes as there are so many changes.
The
textexample has some text that has size inVhunits.