musicbrainz: fix release type #6299
Open
+3
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the MusicBrainz integration to use the canonical 'primary-type' field instead of the deprecated 'type' field when determining album types from release groups.
Changes:
- Updated code to read
'primary-type'instead of'type'from MusicBrainz release group data - Updated test data to reflect the new field name
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| beetsplug/musicbrainz.py | Changed field access from 'type' to 'primary-type' in release group data |
| test/plugins/test_musicbrainz.py | Updated test fixture to use 'primary-type' field name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
snejus
force-pushed
the
musicbrainz-fix-release-type
branch
2 times, most recently
from
4d7ae8a to
f008555
Compare
snejus
force-pushed
the
musicbrainz-fix-release-type
branch
from
f008555 to
8b45423
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'primary-type'field instead of the legacy'type'field when derivinginfo.albumtype.Noticed that
albumtypewas missing from the metadata when I did some imports in my library.