-
Notifications
You must be signed in to change notification settings - Fork 2k
fish: complete files in more places #5927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
46c4524 to
37fac89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the Fish shell completion plugin by enabling filename completion in appropriate contexts, particularly useful for commands like beet import that operate on files and directories.
Changes:
- Modified Fish completion flags to enable filename completion for file/directory path arguments
- Removed
-f(no-file-completion) flag from general command completions to allow files to be completed alongside other options - Changed
-fto-F(force-file-completion) for options that specifically require file or directory paths
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/changelog.rst | Added changelog entry documenting the new filename completion behavior |
| beetsplug/fish.py | Updated Fish completion generation to use -F for file/directory path options and removed -f from general completions to enable filename completion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
snejus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - looks good. Just resolve the conflict in the changelog and we're good to go!
Head branch was pushed to by a user without write access
|
@snejus Fixed the merge conflict. In the future, it might be worth having a system where PRs add release notes in different files to a common directory, and then we have a script that gets run when we release which combines all those files into a single changelog, to avoid merge conflicts. |
Description
Normally, the Fish completion plugin won't complete filenames, which is useful for
beet importand similar! This removes the-f(no filename completion) flag from various places in the output.To Do
docs/to describe it.)docs/changelog.rstto the bottom of one of the lists near the top of the document.)