Skip to content

Conversation

@9999years
Copy link
Contributor

@9999years 9999years commented Aug 11, 2025

Description

Normally, the Fish completion plugin won't complete filenames, which is useful for beet import and similar! This removes the -f (no filename completion) flag from various places in the output.

To Do

  • Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • Tests. (Very much encouraged but not strictly required.)

@github-actions
Copy link

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

@9999years 9999years force-pushed the fish-files branch 4 times, most recently from 46c4524 to 37fac89 Compare January 19, 2026 20:57
@9999years 9999years marked this pull request as ready for review January 19, 2026 21:03
@9999years 9999years requested a review from a team as a code owner January 19, 2026 21:03
Copilot AI review requested due to automatic review settings January 19, 2026 21:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the Fish shell completion plugin by enabling filename completion in appropriate contexts, particularly useful for commands like beet import that operate on files and directories.

Changes:

  • Modified Fish completion flags to enable filename completion for file/directory path arguments
  • Removed -f (no-file-completion) flag from general command completions to allow files to be completed alongside other options
  • Changed -f to -F (force-file-completion) for options that specifically require file or directory paths

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docs/changelog.rst Added changelog entry documenting the new filename completion behavior
beetsplug/fish.py Updated Fish completion generation to use -F for file/directory path options and removed -f from general completions to enable filename completion

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@snejus snejus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - looks good. Just resolve the conflict in the changelog and we're good to go!

@snejus snejus enabled auto-merge January 20, 2026 17:54
auto-merge was automatically disabled January 20, 2026 21:07

Head branch was pushed to by a user without write access

@9999years
Copy link
Contributor Author

@snejus Fixed the merge conflict. In the future, it might be worth having a system where PRs add release notes in different files to a common directory, and then we have a script that gets run when we release which combines all those files into a single changelog, to avoid merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants