This repository was archived by the owner on Jan 20, 2026. It is now read-only.
insertTree: Maintain active children if requested#98
Open
EwanRoycroft wants to merge 3 commits intobbc:masterfrom
Open
insertTree: Maintain active children if requested#98EwanRoycroft wants to merge 3 commits intobbc:masterfrom
EwanRoycroft wants to merge 3 commits intobbc:masterfrom
Conversation
If the maintainActiveChildren option is set, any activeChildren set in the subTreeRootNodeConfig will be assigned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the
maintainActiveChildrenoption toinsertTree(). If enabled, any active children specified in thesubTreeRootNodeConfigwill be assigned once the tree is registered.Motivation and Context
I have a use-case where I want to cache a tree and then restore it at a later date. When I do so, I need the tree to maintain any previously-activated children so the page layout is maintained. I do not want to trigger an
activeChildevent, I need the children to be silently re-activated as the tree is re-registered.How Has This Been Tested?
I have an example of this code running in the demo for bbc/react-lrud-cache-route. All existing jest tests pass.
I have defaulted the
maintainActiveChildrentofalseso it will not affect any current users of this library.Types of changes
Checklist: