Open
Conversation
Turned off css source maps and set js source maps to use “eval-cheap-source-map” for performance.
1 task
judereid
approved these changes
Nov 17, 2020
Contributor
judereid
left a comment
judereid
left a comment
There was a problem hiding this comment.
Nice one @thejoshsmith - looks good!
|
Does this provide useful source maps for Vue SFCs? If so I'm all for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves dev build performance by turning off CSS source maps and setting JS source maps to use “eval-cheap-source-map”.
Fixes #4
Type of change
How Has This Been Tested?
I've tested the dev webpack setup locally combined with batchnz/craft#22