Added two commands: set_compression_level and set_vbr_encoding_quality#341
Added two commands: set_compression_level and set_vbr_encoding_quality#341gesellkammer wants to merge 2 commits intobastibe:masterfrom
Conversation
…y, two configure the compression/quality when writing to a compressed format (ogg or flac)
soundfile.py
Outdated
| _ffi.new("double*", quality), | ||
| _ffi.sizeof("double")) | ||
|
|
||
| if err == SF_FALSE |
|
It seems that the Windows tests for file descriptors are breaking with this PR. That doesn't seem related, though, as this code is not included in the current tests, nor has any interaction with file descriptors. Do you have any idea what's going on here? |
|
I am not familiar with the tests but the errors do not seem to have to do with the changes here. I would be surprised if the unmodified code would not trigger the same errors. |
|
Any news regarding the failing tests? |
|
No idea, sorry. |
|
@bastibe I'm interested in this feature. Any updates on if it can be merged? I also don't see how this code could interact with a Windows file descriptor test. Edit: looks like this feature was added in #447 recently and released in 0.13.0. However, at this time of writing the https://python-soundfile.readthedocs.io/ is still refereing 0.11.0 as the latest version, so that should probably be updated. |
|
Thank you for the heads-up. I hadn't noticed that the docs were out of date. I rebuilt the docs, and they should be up-to-date now. The default redirect still points to 0.11.0, apparently, even though I configured it otherwise. Hopefully this will sort itself out on its own. |
3 participants
These allow to configure the compression/quality when writing to a compressed format (ogg or flac)