Skip to content

fix: order id possible overflow checks with more efficient Relaxed ordering #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nuel-ikwuoma wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

fix: order id possible overflow checks with more efficient Relaxed ordering #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions crates/account-abstraction-core/src/infrastructure/in_memory/mempool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use alloy_primitives::Address;
use std::cmp::Ordering;
use std::collections::{BTreeSet, HashMap};
use std::sync::Arc;
use std::sync::atomic::{AtomicU64, Ordering as AtomicOrdering};
use std::sync::atomic::{AtomicU64, Ordering::Relaxed};
use tracing::warn;

#[derive(Eq, PartialEq, Clone, Debug)]
Expand Down Expand Up @@ -171,7 +171,8 @@ impl InMemoryMempool {

fn get_next_order_id(&self) -> u64 {
self.submission_id_counter
.fetch_add(1, AtomicOrdering::SeqCst)
.fetch_update(Relaxed, Relaxed,
|id| id.checked_add(1)).expect("too many UserOp")
}

pub fn new(config: PoolConfig) -> Self {
Expand Down