fix: add security attributes to wallet dropdown examples #917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….mdx to improve documentation coverage
Collaborator
🟡 Heimdall Review Status
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why? I added rel="noopener noreferrer" to the WalletDropdownFundLink code examples in
docs/onchainkit/wallet/wallet-dropdown-fund-link.mdx
where target="_blank" was used. This ensures the documentation demonstrates security best practices to prevent reverse tabnabbing vulnerabilities.
Notes to reviewers Explicitly showing this attribute in the docs encourages developers to include it in their own implementations when opening links in new tabs.
How has it been tested? Verified that the code examples remain syntactically correct and the markdown renders as expected.