Open
Conversation
Addresses barnybug#331 by upgrading the AWS SDK and mikeg/dns. Requires an update to Go 1.19.
Owner
|
Hi there, thanks for trying! As you may have seen the gucumber package we use for BDD is massively out of date with current Go but I've not found an easy path to getting it working without a big upheaval, so I'll have to hold off until I get some more time to look into this. |
|
Just wondering if there is any update on this, I am having a similar issue with aws sso credentials not working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #331 by upgrading the AWS SDK and mikeg/dns. Requires an update to Go 1.19.
@barnybug I could not get
make testto run using Go 1.17 or 1.19 usingmake test. The failure is:Please when making a pull request:
cli53 has very good existing test coverage, so I'm unlikely to accept a pull request without
a test, but please do ping me if you're struggling to add a test case and I'll help!