fix docs and add test: ignore and only take arrays as arguments#290
Open
agilgur5 wants to merge 2 commits intobabel:masterfrom
Open
fix docs and add test: ignore and only take arrays as arguments#290agilgur5 wants to merge 2 commits intobabel:masterfrom
ignore and only take arrays as arguments#290agilgur5 wants to merge 2 commits intobabel:masterfrom
Conversation
agilgur5
commented
Nov 27, 2019
- just passing a single regex causes errors:
- Error: .ignore must be an array, or undefined
- Error: .only must be an array, or undefined
- just passing a single regex causes errors: - Error: .ignore must be an array, or undefined - Error: .only must be an array, or undefined
- to ensure the docs I just fixed have a passing usage test somewhere
ignore and only take arrays as argumentsignore and only take arrays as arguments
Author
|
Added It might be good to actually test the |
Author
|
The CI failure is unrelated to this code, The test error seen in CI I was getting locally from a fresh clone too, so it predates this PR. The docs commit (which changes no actual code) also got this error in CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.