Set cwd to the location of the closest package.json#282
Open
hughsk wants to merge 1 commit intobabel:masterfrom
Open
Set cwd to the location of the closest package.json#282hughsk wants to merge 1 commit intobabel:masterfrom
cwd to the location of the closest package.json#282hughsk wants to merge 1 commit intobabel:masterfrom
Conversation
This ensures that packages within node_modules that use babelify will resolve babel plugins and presets relative to their own package.json file, instead of resolving plugins and presets from the project root. This is more consistent with the expected behaviour of browserify transforms, which should work in a dependency without any configuration required the end user. Previously, developers would have to install all plugins/presets used by babelify within their dependency tree. Note that this is a breaking change and will require a major version bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that packages within node_modules that use babelify will resolve babel plugins and presets relative to their own
package.jsonfile, instead of resolving plugins and presets from the project root.This is more consistent with the expected behaviour of browserify transforms, which should work in a dependency without any configuration required by the end user. Previously, developers would have to install all plugins/presets used by babelify within their dependency tree.
Note that this is a breaking change — will likely require a major version bump.
Thanks! ✨