Build RPMs and tarballs based on VERSION in Makefile#96
Open
nkadel wants to merge 12 commits intoaws:masterfrom
Open
Build RPMs and tarballs based on VERSION in Makefile#96nkadel wants to merge 12 commits intoaws:masterfrom
nkadel wants to merge 12 commits intoaws:masterfrom
Conversation
…t_global_version_match.py
…pecfile in dist/amazon-efs-utils.spec
…and update Versions
nkadel
changed the title
|
See issue: #95 |
Contributor
|
Hey @nkadel , thanks for the PR. Can you combine your commits into single commit and address the code conflict? |
Author
|
I'd prefer not to make it one commit. How about segregating the .gitignore, from the Makefile, from the .spec commit. |
Contributor
|
Thanks. We suggest to make a single commit, it will be easier to track and manage. Unless you are not only doing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Build RPM tarballs and RPMs based on VERSION in Makefile
Description of changes:
Set the VERSION from the Makefile, not hardcoded in the .spec file.
Set the tarball name based on the VERSION.
Have the "make rpm-only" depend on "make tarball" and "make $(SPECFILE)
Reduce the complexity of the .spec file copying from "%{buildroot}%{builddir}filename", which can be shortened to "filename"
Update .gitignore to include *.spec, *.out, *.orig, *~, *.gz, *.zip and efs-utils/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.