-
Notifications
You must be signed in to change notification settings - Fork 86
chore(CI): fix CI #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CI): fix CI #785
Conversation
This reverts commit ea72e9e.
| # Python <3.11 incompatible with macOS ARM64 runners | ||
| # https://github.com/actions/setup-python/issues/948 | ||
| - python: 3.7 | ||
| os: macos-latest | ||
| - python: 3.8 | ||
| os: macos-latest | ||
| - python: 3.9 | ||
| os: macos-latest | ||
| - python: 3.10 | ||
| os: macos-latest | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should find a way to run these before we merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added macos-15-intel runner. Did you meant to run in at-least one macos if not the latest one?
seebees
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #, if available:
Description of changes:
Issue 1: Retired
macos-13:Issue 2: Python <3.11 incompatible with macOS latest runner
Issue 3: pytest using outdated Python ast module until pytest 7.3.1
Issue 4: Warning about pytest.warns(None) being deprecated on 7.4.0. In pytest 8+, passing None to pytest.warns() will be completely removed.
pytest.warns(None)Issue 5:
-rcflag removed in isort commandIssue 6: Memory error in 32 bit windows machine.
test_GIVEN_two_distinct_valid_encrypted_data_keys_WHEN_serialize_encrypted_data_keys_THEN_deserialize_equals_inputserrored out because of memory error in 32 bit windows OS.Issue 7: Timeout in test vector:
Issue 8 (Flaky not busted): CodeBuild rate limit errors
Removed redundant run of
ci_codebuild-tests.yml. This was getting run withpull.ymlandon pull.Used black for formatting
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: