Python Assignment_1-Sultan Mehmood

[awanjp-dsi]

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

• I can confirm that my changes are working as intended

[xindizhang]

Excellent work! Your code is clean and well-written. Your assignment 1 is complete – no changes needed.

Please see my suggestions for future improvement:

• • In places like:

    if len(clean_a) == len(clean_b) and sorted(clean_a) == sorted(clean_b):
        return True
        
    else:
        return False

You can simplify this by directly returning the boolean expression:
return len(clean_a) == len(clean_b) and sorted(clean_a) == sorted(clean_b)
This makes the code cleaner

• len(clean_a) == len(clean_b) is redundant since comparing the sorted versions already ensures the lengths match. You can simplify the code by removing the length check.
• It’s good practice to add comments or brief documentation to your code so it’s easier for you to review and debug later, and for teammates to understand quickly.
• Quick reminder for future submissions — including a brief PR description is good practice, as it helps your "project-mate" quickly understand what’s going on.