This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Correct indentation of html snippet to match auto indent#151
Open
caleb531 wants to merge 1 commit intoatom:masterfrom
Open
Correct indentation of html snippet to match auto indent#151caleb531 wants to merge 1 commit intoatom:masterfrom
html snippet to match auto indent#151caleb531 wants to merge 1 commit intoatom:masterfrom
Conversation
This makes the indentation of the `html` snippet consistent with how Atom auto-indents its expanded contents when the 'Auto Indent' command is run.
Contributor
|
Personally, I like the "before" style. Of course, this is subjective. I'll let this sit for a while and see what others think about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR deals with this package's
htmlsnippet (the one that expands to a basic HTML document). I noticed that the way theheadandbodytags are indented is inconsistent with how Atom auto-indents the code when you run theEditor: Auto Indentcommand. This PR reduces the indentation of thehtmlsnippet to match what auto-indent would do.Expanded contents of
htmlsnippet:Contents after auto-indent (and the proposed snippet contents):
I don't think any additional tests are needed for a simple change in snippet indentation.
Alternate Designs
You could look at fixing this inconsistency from the opposite angle—changing the auto indent behavior to reflect the current indentation for this snippet. However, that approach seems to me a bit overkill, and I'd much prefer the flatter nesting of the auto indent.
Benefits
Possible Drawbacks
No practical drawbacks, really.
Applicable Issues
None, and all tests are still passing!