This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Open
Conversation
Contributor
Author
|
@50Wliu Wondering if you can take a look and let me know anything I need to address. Thanks! |
Contributor
|
Any update on this? Regarding the PR it seems that it combines two changes, one to enable custom at-rules and another one to enable support for new pseudo-clasess. Also it seems that there's no test for the new added pseudo-classes but it seems that the tests are only checking that pseudo-classes work as expected and they don't test which pseudo-classes are explicitly supported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Add
:defined: https://developer.mozilla.org/en-US/docs/Web/CSS/:defined:focus-visible: https://drafts.csswg.org/selectors-4/#the-focus-visible-pseudo:placeholder-shown: https://developer.mozilla.org/en-US/docs/Web/CSS/:placeholder-shownThe pseudo selectors are sourced from https://github.com/mdn/data/blob/master/css/selectors.json