This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Various snippet improvements#363
Open
dltmtt wants to merge 6 commits intoatom:masterfrom
dltmtt:master
Open
Conversation
Author
|
This is my first PR, I wasn't sure if I should have made multiple ones or not: the number of lines changed is not that big, but, while all relative to snippets, the changes include multiple areas (maybe a new snippet is welcomed but a code refactoring is not). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Alternate Designs
Other coding styleguides (such as brackets on their own line) where considered, but discarded for consistency with previous codebase
Benefits
Possible Drawbacks
People used the the old names may be confused (even though they're basically the same).
I could revert that change if it's unwelcomed.
Applicable Issues