Allow specification of FITS suffixes in ImageFileCollection#727
Open
keflavich wants to merge 3 commits intoastropy:mainfrom
Open
Allow specification of FITS suffixes in ImageFileCollection#727keflavich wants to merge 3 commits intoastropy:mainfrom
ImageFileCollection#727keflavich wants to merge 3 commits intoastropy:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #727 +/- ##
==========================================
+ Coverage 95.49% 95.51% +0.02%
==========================================
Files 30 30
Lines 3931 3949 +18
==========================================
+ Hits 3754 3772 +18
Misses 177 177
Continue to review full report at Codecov.
|
Member
|
@keflavich -- do you have time to add a test for this? If not, I can do that Monday and then merge. I'm not sure why your files are not being picked up since |
Author
|
no time, sorry 🕐 |
This ensures that a refresh picks up the correct files, and avoids having `extension=` arguments all over the place.
mwcraig
force-pushed
the
fits_extension_specification
branch
from
82757fa to
f1d6064
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our observatory writes
.FITfiles, and there appears to be no way atpresent to read these with an
ImageFileCollection.