New tutorial to calculate radial velocity from multiple measurements#550
Draft
alexbinks wants to merge 7 commits intoastropy-learn:mainfrom
Draft
New tutorial to calculate radial velocity from multiple measurements#550alexbinks wants to merge 7 commits intoastropy-learn:mainfrom
alexbinks wants to merge 7 commits intoastropy-learn:mainfrom
Conversation
This tutorial is designed to assess the multiplicity status of a star and calculate a "final" radial velocity for stars when there are several (> 2) individual measurements. Principally the program: 1) reads in a table of RV measurements for any set of stars 2) makes a decision on whether the star is multiple or likely single 3) calculates a final RV from the individual measurements.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
Contributor
|
Thanks for contributing! This looks interesting, but I think you might want to see if the indexing logic can be simplified a bit. At least I don't understand it - but maybe that's just because I don't know that much about the topic. |
on measuring radial velocities. The major modifications are that we now use numpy matrices rather than itertools which is easier to read and runs faster than the previous method.
for more information, see https://pre-commit.ci
Member
|
This looks really promising! Thanks so much for the contribution and we'll work on giving it a robust review ASAP. I'm also going to start a thread in the #learn channel on slack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tutorial is designed to assess the multiplicity status of a
star and calculate a "final" radial velocity for stars when there
are several (> 2) individual measurements. Whilst intended for
RV measurements, the method can be applied for any
parameter that needs to be weighted from different sources.
Principally the program: