Conversation
trying to bring my material up-to-date with astropy-tutorials main
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,475 @@ | |||
| { | |||
There was a problem hiding this comment.
What's the motivation for calling it xid. Is there a more descriptive variable name we could use?
Reply via ReviewNB
There was a problem hiding this comment.
How about crossmatch_id ?
|
Hi @eblur and @kelle, I realize this PR is from a few years ago, but it looks like the tutorial is complete and the review is effectively resolved. If the tutorial is still something you'd like to merge, I think it would just need to be updated with more recent versions of the dependencies (I tried simply to run the notebook with recent versions and it failed). Is this something you'd like to come back to, in order to update it slightly and have it merged? Thanks! |
Part 1 of a specutils tutorial series
How to Load, Plot, and Smooth an Optical Spectrum from SDSS
Ready for review. This is in response to Issue #440