perf(js_run_devserver): allow direct file sync#2017
Draft
ramzesucr wants to merge 1 commit intoaspect-build:2.xfrom
Draft
perf(js_run_devserver): allow direct file sync#2017ramzesucr wants to merge 1 commit intoaspect-build:2.xfrom
ramzesucr wants to merge 1 commit intoaspect-build:2.xfrom
Conversation
|
|
dab5c01 to
29ce861
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Tools like vite have hot reload feature which is useful during development. This feature works when js_run_devserver and ibazel are used. Current experience feels weird due to long reload time thus it invalidates the usage of hot reload. In order to have a better performance I propose synchronizing the non node_module files directly from workspace
workspace source->devserver sandbox, instread of currentworkspace source->bazel-out->devserver sandboxbehaviour. It might not work for every use case, so it's hidden behind direct_sync attribute. The file sync is still necessary after bazel build sincenode_modulesmight have changed.Changes are visible to end-users: yes/no
Test plan