Add support for interactive child processes#902
Add support for interactive child processes#902Silic0nS0ldier wants to merge 1 commit intoaspect-build:mainfrom
Conversation
|
Motivation for this contribution is to allow porting of an edit patches workflow over to Aspect CLI. An interactive shell (running in a temporary directory) is used to allow users a chance to edit and create new commits, on exit (provided there are no uncommitted changes) patches are generated from commits on top of the baseline (a branch, tag, or an initial generated commit when working on source archives). |
|
@thesayyn what's the next step here? |
|
i don't know why the CI is failing but probably not related. I don't have the powers to merge this without having a green CI. |
ed5ddc4 to
34e11db
Compare
|
|
Adds
statusfunction toCommandinstances to allow running of child processes withstdinconnected, such as a shell likebash. Unlikespawnthis implicitly waits for the child process to exit.The function's name
statusis borrowed from the Rust standard library.Changes are visible to end-users: yes
Support for interactive child processes via
ctx.std.process.command("APP_NAME").status().Test plan
Covered by existing test casesNew API surface.New test cases addedNo test cases forspawn(), so nothing to build upon.MODULE.aspectand runaspect test-task.When in the interactive shell use
exit(or whatever applies to your shell) to resume the task.