Add a "browser" field so build tools can find UMD build#813
Open
davidwallacejackson wants to merge 1 commit intoarqex:masterfrom
Open
Add a "browser" field so build tools can find UMD build#813davidwallacejackson wants to merge 1 commit intoarqex:masterfrom
davidwallacejackson wants to merge 1 commit intoarqex:masterfrom
Conversation
|
the |
Author
|
@morlay it could -- I'm not sure of the merits/appropriateness of using umd as the main entrypoint? I did this with |
|
It may not be necessary to export the library in another format, although it is the best option. I think passing libraryExport="default" to webpack config is enough: // config/webpack.config.build.js
const cjsConfig = {
...baseConfig,
output: {
path: outputPath,
library: 'Datetime',
libraryTarget: 'commonjs2',
filename: 'react-datetime.cjs.js',
auxiliaryComment: 'React datetime',
+ libraryExport: "default"
}
};This isn't a Vite issue but a @rollup/plugin-commonjs bug introduced by the refactoring done in rollup/plugins#537. To confirm, you can downgrade |
NiBeliaev
added a commit
to NiBeliaev/react-datetime
that referenced
this pull request
Jul 26, 2022
Add a browser field to fix build issue arqex#813
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Right now, the
package.jsononly indicates the presence of the CommonJS build ofreact-datetime(as"main"). This change exposes the UMD build via the"browser"field.Motivation and Context
Right now, Rollup loads the CJS version of
react-datetimethrough @rollup/plugin-commonjs. That should work just fine, but there are some edge cases in the plugin -- this one in particular seems problematic forreact-datetime.I discovered all this by trying to import
react-datetimein Vite and discovering that the library worked in development (where Vite implements its own esbuild-based CJS -> ESM transformation) but not in production (where Vite uses Rollup). Here's a minimal repro.Including ESM directly would be ideal, but webpack still lists ESM output support as "experimental" in their docs, and I'm assuming this project doesn't particularly want to migrate to another build tool. I tried this out in my local copy and it fixed the issue.
Checklist