[Feature] Add useFixedPosition prop to render picker outside an "overflow: hidden" div#779
Open
AdrielD wants to merge 3 commits intoarqex:masterfrom
Open
[Feature] Add useFixedPosition prop to render picker outside an "overflow: hidden" div#779AdrielD wants to merge 3 commits intoarqex:masterfrom
AdrielD wants to merge 3 commits intoarqex:masterfrom
Conversation
added 3 commits
March 1, 2021 17:10
In some cases, if the datepicker is rendered inside a div with hidden overflow, it will appear cropped. The useFixedPosition flag will tell this component to render the picker relative to it's wrapper, using refs.
|
This should be merged, much need PR |
|
+1 to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds new optional flag, so users can force fixed position rendering and then calculating it's position based on datepicker's wrapper. This is useful in cases where the datepicker is rendered inside a div with hidden overflow and the view is being cropped.
Motivation and Context
I developed this solution while working on a dynamic table that would scroll laterally, with datepickers as headers. When the table had just a few or no rows, the div container would severely crop datepicker's view.
Default datepicker

WIth applied solution:

Also, this PR should solve issue 186
Checklist