You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
Multiple datePickers on one page can cause the DOM rendering to slow down.
In my current project we have tables with 20 to 100 row that can be edited and we see the DOM becomes very big.
Motivation and Context
Amount of nodes in the dom before the change: 71
Amount of nodes in the dom after the change: 2
(Done with document.querySelector(".rdt").getElementsByTagName('*').length)
Checklist
[x] I have not included any built dist files (us maintainers do that prior to a new release)
[ ] I have added tests covering my changes
[x] All new and existing tests pass
[ ] My changes required the documentation to be updated
[ ] I have updated the documentation accordingly
[ ] I have updated the TypeScript 1.8 type definitions accordingly
[ ] I have updated the TypeScript 2.0+ type definitions accordingly
Thanks for the PR. This is something we wanted to tackle soon, but unfortunately we can't just return null when the picker is closed. There are some people that might be animating when the picker is open/closed by custom css, if we just return null we will be breaking the closing animation.
We would need to add kind of a timer to return null some time after the picker has been closed, but not instantly. I think the best approach would be create a new wrapper component that handled that timer. It would receive a prop open, if it changes from true to false it would wait a second or so (this parameter should be configurable) and then re-render to return null.
@arqex we would like to help with this issue. We are right now using a patched version internally. @GertjanVermeir clear on what to do?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Multiple datePickers on one page can cause the DOM rendering to slow down.
In my current project we have tables with 20 to 100 row that can be edited and we see the DOM becomes very big.
Motivation and Context
(Done with document.querySelector(".rdt").getElementsByTagName('*').length)
Checklist
[x] I have not included any built dist files (us maintainers do that prior to a new release)
[ ] I have added tests covering my changes
[x] All new and existing tests pass
[ ] My changes required the documentation to be updated
[ ] I have updated the documentation accordingly
[ ] I have updated the TypeScript 1.8 type definitions accordingly
[ ] I have updated the TypeScript 2.0+ type definitions accordingly