feat: update lassie to sync Retriever (after provider rewrite revert)#173
Merged
hannahhoward merged 2 commits intomasterfrom Feb 1, 2023
Merged
feat: update lassie to sync Retriever (after provider rewrite revert)#173hannahhoward merged 2 commits intomasterfrom
hannahhoward merged 2 commits intomasterfrom
Conversation
* Retriever#Retrieve() calls are now synchronous, so we get to wait for the direct return value and error synchronously * Change the AwaitGet call order and make it cancellable * Make the provider context-cancel aware for cleaner shutdown * Other minor fixes and adaptions to the new Lassie code
rvagg
changed the title
Codecov ReportBase: 5.04% // Head: 5.44% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #173 +/- ##
=========================================
+ Coverage 5.04% 5.44% +0.40%
=========================================
Files 15 14 -1
Lines 1666 1635 -31
=========================================
+ Hits 84 89 +5
+ Misses 1577 1541 -36
Partials 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #167 but against current
master, i.e. with the provider rewrite reverted.It's using filecoin-project/lassie#54 as the "latest" lassie, because that's the newest incarnation of the interface - taking a linkSystem per retrieval.
Unfortunately this won't build because there's a dependency problem involving the infamous btcd breaking change .. and I don't have the patience today to figure out which bit broke that, maybe the go-data-transfer upgrade? It was working with in #167 with a version of lassie that's not too far off this one.