Skip to content

Conversation

@B4nan
Copy link
Member

@B4nan B4nan commented Jan 21, 2026

Summary

Test plan

  • uv lock completes successfully
  • black version updated to 26.1.0
  • CI tests pass

🤖 Generated with Claude Code

Addresses Dependabot alert #65:
- CVE-2024-21503: Regular Expression Denial of Service (ReDoS) vulnerability

Added explicit black>=24.3.0 constraint to dev dependencies and updated uv.lock.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions github-actions bot added this to the 132nd sprint - Tooling team milestone Jan 21, 2026
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Jan 21, 2026
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.01%. Comparing base (ff61ea0) to head (2c4017d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #582   +/-   ##
=======================================
  Coverage   76.01%   76.01%           
=======================================
  Files          42       42           
  Lines        2468     2468           
=======================================
  Hits         1876     1876           
  Misses        592      592           
Flag Coverage Δ
integration 68.96% <ø> (ø)
unit 64.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@B4nan
Copy link
Member Author

B4nan commented Jan 21, 2026

No idea if this is correct, feel free to resolve the security issue otherwise.

@B4nan B4nan requested a review from vdusek January 21, 2026 14:01
@B4nan B4nan added the adhoc Ad-hoc unplanned task added during the sprint. label Jan 21, 2026
@vdusek
Copy link
Contributor

vdusek commented Jan 21, 2026

No idea if this is correct, feel free to resolve the security issue otherwise.

Isn't this just a false positive, taking into account that this is a transitive dependency of pydoc, and we use pydoc as a dev dependency? Meaning the black is not part of our production package.

Of course, it is completely wrong for pydoc (and its dependencies) to use black (linter & formatter) as a production dependency. But it is what it is...

@B4nan
Copy link
Member Author

B4nan commented Jan 21, 2026

Security issues in dev dependencies are also valid, because we use them in our CI where we have various secrets that could leak. But you are right that those issues are less important and often invalid for us. Still, if we can resolve them with a dependency bump, we should do so.

What's the alternative here? I guess waiting for pydoc to update their dependencies? We can surely wait a bit with this, I was mostly testing how claude handles this kind of task, since it will get worse once we include more repositories in those checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants