Fix concurrent issue in SingleSignOutFilter#doFilter method#874
Open
taydy wants to merge 1 commit intoapereo:masterfrom
Open
Fix concurrent issue in SingleSignOutFilter#doFilter method#874taydy wants to merge 1 commit intoapereo:masterfrom
taydy wants to merge 1 commit intoapereo:masterfrom
Conversation
Author
|
@mmoayyed Could you please take a look at this issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix concurrency issues in
SingleSignOutFilter#doFiltermethod.In the
SingleSignOutFilter#doFiltermethod, synchronization is added to prevent concurrent execution and ensure thread safety.Before the repair, if
SingleSignOutFilter#initis not executed for initialization, when multiple threads execute concurrently, one thread may be executing theHANDLER.init()method, the safeParameters inSingleSignOutHandlerhave not yet been initialized, and other threads have begun executingHANDLER.process(request, response), which will causes the program to throw a NullPointerException.