[SPARK-54939][PYTHON][TESTS][FOLLOWUP] Handle PyArrow version difference in type coercion tests #53873
+52
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA Issue Information=== Sub-task SPARK-54939 === This comment was automatically generated by GitHub Actions |
Comment on lines
+46
to
+47
| if have_pyarrow: | ||
| import pyarrow as pa |
Contributor
There was a problem hiding this comment.
Nit: I find this slightly more readable if you reuse the variable name in the skip clauses.
Suggested change
| if have_pyarrow: | |
| import pyarrow as pa | |
| if have_pyarrow: | |
| import pyarrow as pa | |
| pyarrow_19_or_greater = LooseVersion(pa.__version__) >= LooseVersion("19.0.0") |
Contributor
Author
There was a problem hiding this comment.
thanks for the suggestion! adopted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Skip
test_pandas_instances_coercionon PyArrow < 19 and add a separate test for PyArrow < 19 behavior.Why are the changes needed?
PyArrow < 19 and >= 19 have different
pa.array()type coercion behavior for ArrowDtype-backed Series.Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested with PyArrow 18~22.
Was this patch authored or co-authored using generative AI tooling?
No