[#2489] Add CITATION.cff for Apache Shiro#2518
[#2489] Add CITATION.cff for Apache Shiro#2518iampratap7997-dot wants to merge 3 commits intoapache:mainfrom
Conversation
|
Hi, |
jbampton
left a comment
There was a problem hiding this comment.
The license check has failed.
Most files do need to have the standard ASF license header.
Otherwise you need to add an exclude in the repo root POM.xml file in the "apache-rat-plugin"
Hi @jbampton, thank you for reviewing! Since I do not have permission to edit the pom.xml to exclude CITATION.cff from the RAT license check, I leave it to the maintainers to handle the exclusion. Thanks! |
|
Hi, you absolutely have permission to modify Pom.xml. Please do so. |
Co-authored-by: John Bampton <jbampton@users.noreply.github.com>
Hi, |
You have added the license header now that should be enough. You do not need to update the pom.xml since you added the license header. You do either one, not both. |
|
John, thanks for the clarification! |
Thankyou @jbampton for this information. |
Following this checklist to help us incorporate your contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
[#XXX] - Fixes bug in SessionManager,where you replace
#XXXwith the appropriate GitHub issue. Best practiceis to use the GitHub issue title in the pull request title and in the first line of the commit message.
fixes #XXXif merging the PR should close a related issue.mvn verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like
[DOC] - Add javadoc in SessionManager.If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
Fixes We can add a CITATION file to the repository to help users correctly cite the Shiro software #2489