RATIS-2239. Publish build scans to develocity.apache.org#1212
Merged
adoroszlai merged 1 commit intoapache:masterfrom Jan 17, 2025
Merged
RATIS-2239. Publish build scans to develocity.apache.org#1212adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@clayburn please take a look when you have some time |
clayburn
approved these changes
Jan 16, 2025
clayburn
left a comment
clayburn
left a comment
There was a problem hiding this comment.
One comment just for info, but LGTM 👍🏻
| <fileFingerprints>false</fileFingerprints> | ||
| <buildLogging>false</buildLogging> | ||
| <testLogging>false</testLogging> | ||
| <fileFingerprints>true</fileFingerprints> |
There was a problem hiding this comment.
These three trues for fileFingerprints, buildLogging, and testLogging are all defaults if you'd prefer to just omit them. But no problems explicitly declaring defaults if that is what you prefer to do.
Contributor
There was a problem hiding this comment.
@clayburn , thanks for the info. @adoroszlai , please see which one is more preferable.
Contributor
Author
There was a problem hiding this comment.
I prefer explicitly setting these.
szetszwo
approved these changes
Jan 16, 2025
| <fileFingerprints>false</fileFingerprints> | ||
| <buildLogging>false</buildLogging> | ||
| <testLogging>false</testLogging> | ||
| <fileFingerprints>true</fileFingerprints> |
Contributor
There was a problem hiding this comment.
@clayburn , thanks for the info. @adoroszlai , please see which one is more preferable.
Contributor
Author
szetszwo
pushed a commit
to szetszwo/ratis
that referenced
this pull request
Mar 30, 2025
szetszwo
pushed a commit
to szetszwo/ratis
that referenced
this pull request
May 23, 2025
szetszwo
pushed a commit
to szetszwo/ratis
that referenced
this pull request
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Publish data about CI builds to
develocity.apache.org.Downgrade
develocity-maven-extension, because the server atdevelocity.apache.orgdoes not yet support 1.23.https://issues.apache.org/jira/browse/RATIS-2239
How was this patch tested?
Similar config file is already used for Ozone.
CI:
https://github.com/adoroszlai/ratis/actions/runs/12805619564