-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update time zone spec for more timezone support #17543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates timezone support in Apache Pinot by synchronizing with Presto's timezone definitions. The changes add new timezone entries, update comments for deprecated timezones, and remove unused fields and helper methods from the codebase.
Changes:
- Added 26 new timezone entries (e.g., Africa/Juba, Asia/Hebron, America/Ciudad_Juarez)
- Updated comment for deprecated US/Pacific-New timezone with removal reference
- Removed unused static fields and helper methods related to offset timezone calculations
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| zone-index.properties | Adds new timezone entries and updates deprecated timezone comment |
| TimeZoneKey.java | Removes unused offset timezone arrays and helper methods, refactors code formatting |
| DateTimeUtils.java | Removes unused FIXED_ZONE_OFFSET array and VARIABLE_ZONE constant |
pinot-common/src/main/java/org/apache/pinot/common/function/TimeZoneKey.java
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17543 +/- ##
============================================
+ Coverage 63.20% 63.21% +0.01%
- Complexity 1476 1477 +1
============================================
Files 3170 3170
Lines 189523 189513 -10
Branches 28997 28999 +2
============================================
+ Hits 119779 119802 +23
+ Misses 60451 60414 -37
- Partials 9293 9297 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
satwik-pachigolla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is purely adding more timezone identifier support. Looks good to me!
zone-index.propertiesto include the new added timezone support from Presto