Skip to content

Conversation

@Jackie-Jiang
Copy link
Contributor

  • Update zone-index.properties to include the new added timezone support from Presto
  • Remove some unused fields

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates timezone support in Apache Pinot by synchronizing with Presto's timezone definitions. The changes add new timezone entries, update comments for deprecated timezones, and remove unused fields and helper methods from the codebase.

Changes:

  • Added 26 new timezone entries (e.g., Africa/Juba, Asia/Hebron, America/Ciudad_Juarez)
  • Updated comment for deprecated US/Pacific-New timezone with removal reference
  • Removed unused static fields and helper methods related to offset timezone calculations

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
zone-index.properties Adds new timezone entries and updates deprecated timezone comment
TimeZoneKey.java Removes unused offset timezone arrays and helper methods, refactors code formatting
DateTimeUtils.java Removes unused FIXED_ZONE_OFFSET array and VARIABLE_ZONE constant

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.21%. Comparing base (92b6182) to head (beec045).

Files with missing lines Patch % Lines
.../org/apache/pinot/common/function/TimeZoneKey.java 10.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17543      +/-   ##
============================================
+ Coverage     63.20%   63.21%   +0.01%     
- Complexity     1476     1477       +1     
============================================
  Files          3170     3170              
  Lines        189523   189513      -10     
  Branches      28997    28999       +2     
============================================
+ Hits         119779   119802      +23     
+ Misses        60451    60414      -37     
- Partials       9293     9297       +4     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.17% <10.00%> (+0.01%) ⬆️
java-21 63.16% <10.00%> (-0.02%) ⬇️
temurin 63.21% <10.00%> (+0.01%) ⬆️
unittests 63.21% <10.00%> (+0.01%) ⬆️
unittests1 55.56% <10.00%> (+0.01%) ⬆️
unittests2 34.03% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@satwik-pachigolla satwik-pachigolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is purely adding more timezone identifier support. Looks good to me!

@Jackie-Jiang Jackie-Jiang merged commit 52d0f8c into apache:master Jan 21, 2026
18 checks passed
@Jackie-Jiang Jackie-Jiang deleted the upgrade_timezonekey branch January 21, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants