HDDS-13621. NPE in OzoneManagerRatisServer.checkRetryCache#9711
Merged
jojochuang merged 1 commit intoapache:masterfrom Feb 5, 2026
Merged
HDDS-13621. NPE in OzoneManagerRatisServer.checkRetryCache#9711jojochuang merged 1 commit intoapache:masterfrom
jojochuang merged 1 commit intoapache:masterfrom
Conversation
ss77892
changed the title
cchung100m
approved these changes
Feb 5, 2026
Contributor
cchung100m
left a comment
cchung100m
left a comment
There was a problem hiding this comment.
LGTM, thanks to @ss77892
Contributor
|
Merged. Thanks @ss77892 for the patch and @cchung100m for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In HDDS-11558, we introduced a retry idempotent. If a retry came from the client, we always want to return the existing reply. But it doesn't cover the case when a failed request landed in the retry cache. In this case, we can't build the response properly, and NPE is thrown.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13621
How was this patch tested?
ozone freon ommg on the cluster where the OM process is continuously struggling from the JVM pauses. Without the patch, the retry operation never succeeded, so the number of correct writes was always less than expected. With the provided patch, the success rate of retries was always 100%.
I attempted to create a unit test, but I found it quite challenging to replicate the scenario where a pause occurs after the request passes the check for the active leader. As a result, the request ended up in the RetryCache, but it failed when no leader was available.