HDDS-14534. Refactor ObjectEndpoint get/delete to use ObjectOperationHandler#9710
Open
Russole wants to merge 4 commits intoapache:masterfrom
Open
HDDS-14534. Refactor ObjectEndpoint get/delete to use ObjectOperationHandler#9710Russole wants to merge 4 commits intoapache:masterfrom
Russole wants to merge 4 commits intoapache:masterfrom
Conversation
Gargi-jais11
reviewed
Feb 5, 2026
Contributor
Gargi-jais11
left a comment
There was a problem hiding this comment.
Thanks @Russole for the patch. Please find the inline comment.
| } else { | ||
|
|
||
| } catch (IOException | RuntimeException ex) { | ||
| if (uploadId == null) { |
Contributor
There was a problem hiding this comment.
I think you missed this part.
When uploadId != null and an exception occurs, the code doesn't update listPartsFailureStats. The catch block only updates getKeyFailureStats when uploadId == null
Contributor
Author
There was a problem hiding this comment.
Thanks @Gargi-jais11 for the review. Fixed in the latest commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Continue HDDS-14398 by refactoring GET and DELETE handlers in ObjectEndpoint to use ObjectOperationHandler.
deleteObjectTaggingandgetObjectTaggingintoObjectTaggingHandlerand implementhandleDeleteRequestandhandleGetRequestinObjectTaggingHandlerusing these methods.handleDeleteRequestandhandleGetRequestinObjectEndpoint, moving existing logic from get and delete, but keepOMExceptionhandling in the original method, and drop:EndpointTestUtilsto set the mocked request method for GET/PUT/DELETE calls, preventing null context/method failures when routing through the handler chain.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14534
How was this patch tested?
All CI checks passed.