HDDS-14377. Refactor OmLifecycleConfiguration#Builder#9688
Open
YutaLin wants to merge 2 commits intoapache:HDDS-8342from
Open
HDDS-14377. Refactor OmLifecycleConfiguration#Builder#9688YutaLin wants to merge 2 commits intoapache:HDDS-8342from
YutaLin wants to merge 2 commits intoapache:HDDS-8342from
Conversation
Contributor
Author
|
Hi @ChenSammi, can you help me take a look? thanks! |
chungen0126
requested review from
ChenSammi,
chungen0126,
ivandika3 and
xichen01
and removed request for
ChenSammi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In master branch, WithObjectID#Builder is refactored to have validate(), buildObject() and build(), and build() is final.
After merge with master branch, OmLifecycleConfiguration#Builder, buildObject() and buildAndValid() look not consistent with WithObjectID#Builder style. Let's refactor the OmLifecycleConfiguration#Builder so that build() can be called to replace current buildObject() and buildAndValid().
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14377
How was this patch tested?
workflow run: https://github.com/YutaLin/ozone/actions/runs/21461412215