HDDS-14411. Combine CompactionService and CompactDBService#9663
Open
weimingdiit wants to merge 1 commit intoapache:masterfrom
Open
HDDS-14411. Combine CompactionService and CompactDBService#9663weimingdiit wants to merge 1 commit intoapache:masterfrom
weimingdiit wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@jojochuang @ChenSammi @adoroszlai Hi, could you please review this PR? |
sadanand48
reviewed
Jan 28, 2026
|
|
||
| try { | ||
| // Find CF Handler | ||
| RocksDatabase.ColumnFamily columnFamily = rocksDatabase.getColumnFamily(tableName); |
Contributor
There was a problem hiding this comment.
IMO we have still not eliminated duplicate code here via this patch, both compactFully and compactTableOnDemand have similar code.
A better way would be to keep the CompactDBService.java and rename it to something like CompactDBUtil and include a method that does same as compactFully which can be used in both the places
Contributor
Author
There was a problem hiding this comment.
@sadanand48 Thanks, I will update the code.
Contributor
Author
There was a problem hiding this comment.
@sadanand48 I have updated the code, please review it again.
weimingdiit
force-pushed
the
HDDS-14411
branch
from
896b188 to
8b22f6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Both CompactDBService and CompactionService offer excellent database compression performance for the OM Active Object Space (AOS). They appear very similar. We should combine these two services and use only one of them.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14411
How was this patch tested?
unit tests，workflow