HDDS-13855. Move ACL check in Volume, Bucket and Keys requests to preExecute#9653
Open
ss77892 wants to merge 2 commits intoapache:masterfrom
Open
HDDS-13855. Move ACL check in Volume, Bucket and Keys requests to preExecute#9653ss77892 wants to merge 2 commits intoapache:masterfrom
ss77892 wants to merge 2 commits intoapache:masterfrom
Conversation
ss77892
changed the title
jojochuang
reviewed
Jan 24, 2026
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
A lot of request handlers such as OMKeyAclRequest operates on OBS buckets. They have a sibling request like OMKeyAclRequestWithFSO, which operates on FSO buckets.
They are very similar but unfortunately are different request handlers for different buckets, and we need to move the acl check to preExecute() for them too.
| bucket = resolvedBucket.realBucket(); | ||
| key = objectParser.getKey(); | ||
|
|
||
| // check Acl |
Contributor
There was a problem hiding this comment.
we need to repeat this for OMKeyAclRequestWithFSO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-13855. Move ACL check in Volume, Bucket and Keys requests to preexecute.
Please describe your PR in detail:
We are moving ACL checks from the validate cache method to the pre-execute stage to avoid multiple executions on all Ratis nodes. That's the second attempt, the first pr : #9297. In this PR all previous comments were addressed.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13855
How was this patch tested?
Manual tests, UT