HDDS-8576. Close RocksDB instance in RDBStore if RDBStore's initialization fails after RocksDB instance creation#4692
Merged
smengcl merged 3 commits intoapache:masterfrom May 11, 2023
Merged
Conversation
…ation fails after RocksDB instance creation
smengcl
reviewed
May 10, 2023
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
Outdated
Show resolved
Hide resolved
smengcl
reviewed
May 10, 2023
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java
Outdated
Show resolved
Hide resolved
smengcl
reviewed
May 10, 2023
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java
Show resolved
Hide resolved
swamirishi
reviewed
May 10, 2023
Contributor
swamirishi
left a comment
swamirishi
left a comment
There was a problem hiding this comment.
Minor queries LGTM otherwise
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RocksDatabase.java
Show resolved
Hide resolved
swamirishi
reviewed
May 10, 2023
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RocksDatabase.java
Show resolved
Hide resolved
swamirishi
reviewed
May 10, 2023
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RocksDatabase.java
Outdated
Show resolved
Hide resolved
hemantk-12
force-pushed
the
HDDS-8576
branch
2 times, most recently
from
7dd515e to
cfc9c28
Compare
smengcl
approved these changes
May 10, 2023
Contributor
|
Thanks @hemantk-12 for the fix. Thanks @swamirishi for reviewing this as well. |
errose28
added a commit
to errose28/ozone
that referenced
this pull request
May 17, 2023
* master: (78 commits) HDDS-8575. Intermittent failure in TestCloseContainerEventHandler.testCloseContainerWithDelayByLeaseManager (apache#4688) HDDS-7241. EC: Reconstruction could fail with orphan blocks. (apache#4718) HDDS-8577. [Snapshot] Disable compaction log when loading metadata for snapshot (apache#4697) HDDS-7080. EC: Offline reconstruction needs better logging (apache#4719) HDDS-8626. Config thread pool in ReplicationServer (apache#4715) HDDS-8616. Underreplication not fixed if all replicas start decommissioning (apache#4711) HDDS-8254. Close containers when volume reaches utilisation threshold (apache#4583) HDDS-8254. Close containers when volume reaches utilisation threshold (apache#4583) HDDS-8615. Explicitly show EC block type in 'ozone debug chunkinfo' command output (apache#4706) HDDS-8623. Delete duplicate getBucketInfo in OMKeyCommitRequest (apache#4712) HDDS-8339. Recon Show the number of keys marked for Deletion in Recon UI. (apache#4519) HDDS-8572. Support CodecBuffer for protobuf v3 codecs. (apache#4693) HDDS-8010. Improve DN warning message when getBlock does not find the block. (apache#4698) HDDS-8621. IOException is never thrown in SCMRatisServer.getRatisRoles(). (apache#4710) HDDS-8463. S3 key uniqueness in deletedTable (apache#4660) HDDS-8584. Hadoop client write slowly when stream enabled (apache#4703) HDDS-7732. EC: Verify block deletion from missing EC containers (apache#4705) HDDS-8581. Avoid random ports in integration tests (apache#4699) HDDS-8504. ReplicationManager: Pass used and excluded node separately for Under and Mis-Replication (apache#4694) HDDS-8576. Close RocksDB instance in RDBStore if RDBStore's initialization fails after RocksDB instance creation (apache#4692) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change is to close RocksDB instance if RDBStore creations fails after RocksDB's instance creation.
It also includes proper closing of
OmMetadataManagerImplin its construct and while loading snapshot cache due to any failure.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8576
How was this patch tested?
Existing tests.
Before the change, integration tests I added as part of HDDS-8389, were failing most of the time.
Failed run example#1: https://github.com/hemantk-12/ozone/actions/runs/4929699855/jobs/8812911004
Failed run example#2: https://github.com/apache/ozone/actions/runs/4919751367/jobs/8787838665
After the change: https://github.com/hemantk-12/ozone/actions/runs/4932359606/jobs/8815309274