Skip to content

Conversation

@ThePassionate
Copy link
Contributor

NuttX-Apps NIST-STS Testing Directory Reorganization

Overview

Reorganize NIST Statistical Test Suite (nist-sts) testing module by moving it from the top-level testing/ directory into testing/drivers/ directory structure for better code organization and alignment with other driver-related tests.

Motivation

The NIST-STS tests utilize the /dev/random device, making them driver-related tests. Moving them into the testing/drivers/ directory provides:

  • Better organization: Groups all driver-related tests in a unified location
  • Consistency: Aligns with the existing directory structure for crypto and other driver tests
  • Maintainability: Easier to manage and discover driver-specific test suites

Changes

  • Move testing/nist-sts/testing/drivers/nist-sts/
  • Update build configuration files:
    • CMakeLists.txt (path references)
    • Makefile (source paths)
    • Make.defs (build variables)
  • Preserve all test patches and Kconfig settings

Backward Compatibility

No breaking changes. The test functionality remains identical; only the directory location is updated.

@acassis
Copy link
Contributor

acassis commented Jan 28, 2026

@ThePassionate following this logic, shouldn't it be better to move nist-sts to inside testing/drivers/crypto/? That seems the proper place, since nist-sts is not a test for all drivers, but for specific crypto random driver. Just my 2 cents

@ThePassionate
Copy link
Contributor Author

@ThePassionate following this logic, shouldn't it be better to move nist-sts to inside testing/drivers/crypto/? That seems the proper place, since nist-sts is not a test for all drivers, but for specific crypto random driver. Just my 2 cents

Yes, you are right! Nist-sts is for testing /dev/random, so let me change it into rng directory.

Copy link
Contributor

@acassis acassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to testing/drivers/rng

@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented Jan 28, 2026

move to testing/drivers/rng

the name come from 3rd party project, it's better to keep as before so the user can know it's origin directly. @acassis

@acassis
Copy link
Contributor

acassis commented Jan 28, 2026

move to testing/drivers/rng

the name come from 3rd party project, it's better to keep as before so the user can know it's origin directly. @acassis

No, I mean: apps/testing/drivers/rng/nist-sts

My initial suggestion was apps/testing/drivers/crypto/ but @ThePassionate suggested rng

@ThePassionate
Copy link
Contributor Author

move to testing/drivers/rng

the name come from 3rd party project, it's better to keep as before so the user can know it's origin directly. @acassis

No, I mean: apps/testing/drivers/rng/nist-sts

My initial suggestion was apps/testing/drivers/crypto/ but @ThePassionate suggested rng

have fixed. Thanks!

Move NIST Statistical Test Suite (nist-sts) testing module from testing/drivers/
into testing/drivers/rng/ directory to better organize RNG (random number generator)
related tests that utilize /dev/random device.

Changes:
- Create testing/drivers/rng/ directory structure
- Move nist-sts from testing/drivers/ to testing/drivers/rng/nist-sts
- Update build configuration file paths:
  - CMakeLists.txt
  - Makefile
  - Make.defs
- Maintain all test patches and Kconfig settings

Signed-off-by: makejian <makejian@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 merged commit 367e9dc into apache:master Jan 29, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants