[QDP] File and streaming Quantum Data Loader#1010
Merged
guan404ming merged 2 commits intoapache:mainfrom Feb 7, 2026
Merged
Conversation
Member
|
Please resolve conflicts |
guan404ming
approved these changes
Feb 4, 2026
Member
guan404ming
left a comment
There was a problem hiding this comment.
Overall looks nice, left one question
Member
There was a problem hiding this comment.
I think both _source_type string and three boolean flags track the same information. Maybe we could consider to keep only booleans since this would eliminate ~10 lines of validation logic in _create_iterator().
789c5f6 to
9b001d9
Compare
Member
|
Overall looks nice! Please help resolve conflict and I think we are good to merge~ |
Member
|
@rich7420 Please solve conflicts |
400Ping
approved these changes
Feb 6, 2026
Member
|
Overall LGTM |
9b001d9 to
73cad0c
Compare
Member
|
Thanks for the update! |
Contributor
Author
|
thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR
Adds file-backed and streaming Parquet data sources to the Quantum Data Loader. Users can call
.source_file(path)or.source_file(path, streaming=True)and iterate in batches. PyO3 loader bindings are restored soQuantumDataLoaderworks with synthetic, file, and streaming sources.DataSource::InMemoryandDataSource::Streaming;new_from_file(full read, supports .parquet/.arrow/.npy/.pt/.pb etc.) andnew_from_file_streaming(Parquet, chunked read). Sharedpath_extension_lower,take_batch_from_source, named constants, first-chunk buffer reuse. Basis encoding fix: state vector allocated as Float64 to match kernel, then converted to engine precision.PyQuantumLoader,create_synthetic_loader,create_file_loader,create_streaming_file_loader(Linux only).batch_limit=None→usize::MAX; path from str or Path; file/streaming build inpy.detach().source_file(path, streaming=False),_create_iterator(). Streaming requires.parquet.Related Issues or PRs
Related to #969
Changes Made
Breaking Changes
Checklist