KNOX-3247 - Knox LDAP Server with Pluggable Backend#1144
Open
lmccay wants to merge 3 commits intoapache:masterfrom
Open
KNOX-3247 - Knox LDAP Server with Pluggable Backend#1144lmccay wants to merge 3 commits intoapache:masterfrom
lmccay wants to merge 3 commits intoapache:masterfrom
Conversation
Test Results7 tests 7 ✅ 1s ⏱️ Results for commit 5c59d0e. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-1234 - KNOX-3247 - Knox LDAP Server with Pluggable Backend
What changes were proposed in this pull request?
By exposing an LDAP interface from Knox, we can provide a rich set of backend implementations that can:
The LDAP Server proxy feature normalizes the consumer facing schema and returns the proxied schema results. This is a standard/common LDAP Proxy pattern. It also needs to be able to reverse the mapping for queries that come from a result that includes the backend schema such as the DN. So, consumers can use both the internal and external DNs for searches.
This PR adds a new GatewayService called KnoxLDAPServer that uses ServiceLoader to provide an SPI for backend implementations. It includes a file based backend for testing and an LDAP backend to proxy access to other external LDAP servers.
How was this patch tested?
New unit tests have been added for those things that can be mocked and tested.
We will need to add additional integration tests with an actual backend deployed.
Manually tested both the file based and LDAP Server based backends.
Used the existing Demo LDAP Server as the proxied LDAP Server.
Integration Tests
(Please add or update integration tests
.github/workflows/testsfor the feature you are adding. If no unit test is added, please explain why. Check out.github/workflows/tests/README.mdfor instructions)