KNOX-3158: Enhancing the maintainability of knox-shell#1056
Open
Raghav-Mah3shwari wants to merge 1 commit intoapache:masterfrom
Open
KNOX-3158: Enhancing the maintainability of knox-shell#1056Raghav-Mah3shwari wants to merge 1 commit intoapache:masterfrom
Raghav-Mah3shwari wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
@Raghav-Mah3shwari - please show that you have tested the shell functionality related to the changes that you have made. We need to know that there has been some manual testing for the shell work since much of that is hard to unit test. Some example output exercising the the affected code paths would be a good way to do this. |
Contributor
Author
|
Hi @lmccay can you give me some suggestions on how to test it and verify it. Thanks in advance |
smolnar82
requested changes
Jul 17, 2025
Contributor
smolnar82
left a comment
smolnar82
left a comment
There was a problem hiding this comment.
Please use Knox's MesageFactory feature and the relevant interface (in this case this would be org.apache.knox.gateway.shell.KnoxShellMessages) instead of the plain Logger approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increasing the maintainability of the code by reducing code smells from gateway-shell
How was this patch tested?
The changes were made in local first then a maven build was triggered. The build was successful