Pipe: Fixed the missing privilege check of aligned series in tsFile scan parser & Fixed the missed parsing of insertNode privilege #17055
+110
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17055 +/- ##
============================================
+ Coverage 39.24% 39.26% +0.01%
Complexity 282 282
============================================
Files 5105 5105
Lines 341457 341446 -11
Branches 43517 43517
============================================
+ Hits 134015 134067 +52
+ Misses 207442 207379 -63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jt2594838
approved these changes
Jan 21, 2026
jt2594838
reviewed
Jan 22, 2026
Comment on lines
632
to
640
| if (!isAligned) { | ||
| if ((chunkHeader.getChunkType() & TsFileConstant.TIME_COLUMN_MASK) | ||
| == TsFileConstant.TIME_COLUMN_MASK) { | ||
| timeChunkList.add( | ||
| new Chunk(chunkHeader, tsFileSequenceReader.readChunk(-1, chunkHeader.getDataSize()))); | ||
| isMultiPageList.add(marker == MetaMarker.TIME_CHUNK_HEADER); | ||
| return true; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This is weird, nonaligned chunk should not have time column.
jt2594838
approved these changes
Jan 22, 2026
jt2594838
approved these changes
Jan 22, 2026
Caideyipi
changed the title
jt2594838
approved these changes
Jan 22, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title said.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR