HBASE-29851 Add more directories to yetus skip-dirs

[ndimiduk]

No description provided.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for branch
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 4s		Maven dependency ordering for patch
			_ Other Tests _
		1m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7670/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7670
Optional Tests
uname	Linux 8ef8939a9792 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 064c70e
Max. process+thread count	41 (vs. ulimit of 30000)
modules	C: U:
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7670/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 31s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ master Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for branch
+1 💚	spotless	0m 49s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 5s		Maven dependency ordering for patch
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	shellcheck	0m 1s		No new issues.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+0 🆗	asflicense	0m 0s		ASF License check generated no output?
		3m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7670/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7670
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs spotless
uname	Linux 29874be86a40 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 064c70e
Max. process+thread count	49 (vs. ulimit of 30000)
modules	C: U:
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7670/1/console
versions	git=2.34.1 maven=3.9.8 shellcheck=0.8.0
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[petersomogyi]

I'm not 100% sure on the conf. In certain cases it might be useful to run a full test when the default config changes as it could introduce problems.

[Apache9]

IIRC, if we change the files under dev-support, we will still trigger a yetus run, but just some very basic checks?

[ndimiduk]

I'm not 100% sure on the conf. In certain cases it might be useful to run a full test when the default config changes as it could introduce problems.

I considered this. My conclusion is that hbase-default.xml is a resource read from https://github.com/apache/hbase/blob/master/hbase-common/src/main/resources/hbase-default.xml . Unit tests don't use conf at all. Maybe there's some integration test that references conf, but it own't be a junit/maven test. I don't think.

IIRC, if we change the files under dev-support, we will still trigger a yetus run, but just some very basic checks?

That's my understanding, yes, the General Checks still apply because they're evaluating changed files. Module selection is part of the unit testing check, in our case, junit + maven.