Fix invalid POM caused by missing jackson-dataformat-yaml version#7970
Merged
JinwooHwang merged 1 commit intoapache:developfrom Dec 11, 2025
Merged
Conversation
The geode-core module declares jackson-dataformat-yaml as a dependency without specifying a version, relying on DependencyConstraints.groovy to provide it. However, DependencyConstraints.groovy was missing the version constraint for com.fasterxml.jackson.dataformat.* artifacts. This caused the published geode-core-2.0.0.pom to have jackson-dataformat-yaml with no <version> tag, making the POM invalid according to Maven specification. Maven refuses to process ANY transitive dependencies from an invalid POM, which caused all dependencies (antlr, jopt-simple, micrometer-core, shiro-core, jakarta.transaction-api, geode-management, geode-deployment-legacy, rmiio) to not be pulled transitively. This fix adds the missing dependency constraint for jackson-dataformat-yaml, using jackson.version (2.17.0) to match other Jackson artifacts. Issue reported by Leon during 2.0.0.RC2 testing.
Contributor
Author
|
Hi @sboorlagadda and @leonfin. Please let me know if I missed anything. Thank you for your support. |
Contributor
|
hi @JinwooHwang yes looks good. Thank you! |
Contributor
Author
|
Thank you so much @leonfin |
sboorlagadda
approved these changes
Dec 11, 2025
Contributor
Author
|
@sboorlagadda . I am so grateful for your support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The published
geode-core-2.0.0.pomwas invalid, causing Maven to refuse processing ANY transitive dependencies. Users had to manually add all dependencies that should have been transitive.Maven Error:
Dependency Tree (broken):
Root Cause
geode-core/build.gradleline 207 declaresjackson-dataformat-yamlwithout a version:runtimeOnly('com.fasterxml.jackson.dataformat:jackson-dataformat-yaml')This relies on
DependencyConstraints.groovyto provide the version via the BOM. However,DependencyConstraints.groovydefined constraints for:com.fasterxml.jackson.core.*com.fasterxml.jackson.datatype.*com.fasterxml.jackson.dataformat.*(MISSING!)Result: The published POM had a dependency with no
<version>tag, making it invalid per Maven spec. Maven rejects invalid POMs and refuses to process their transitive dependencies.Solution
Added the missing dependency constraint to
DependencyConstraints.groovy:This adds
jackson-dataformat-yaml:2.17.0to thegeode-all-bomdependency management, ensuring the publishedgeode-corePOM is valid.Verification
After fix, dependency tree works correctly:
No invalid POM warnings. All transitive dependencies are pulled correctly.
Impact
This fixes the invalid POM that was blocking all transitive dependencies, including:
Users no longer need to manually declare these dependencies.
Testing
geode-all-bomcontainsjackson-dataformat-yaml:2.17.0geode-corePOM imports BOM in<dependencyManagement>Issue discovered by: @leonfin during 2.0.0.RC2 testing
For all changes, please confirm:
develop)?gradlew buildrun cleanly?