Closed
Conversation
Member
Author
|
@robtandy This is now ready for review. I was able to run the benchmarks this morning based on these instructions. |
robtandy
suggested changes
Mar 8, 2025
|
|
||
| ```shell | ||
| ray job submit --address='http://localhost:8265' \ | ||
| --runtime-env-json='{"pip":["datafusion", "tabulate", "boto3", "duckdb"], "py_modules":["/home/andy/git/apache/datafusion-ray/target/wheels/datafusion_ray-0.1.0-cp38-abi3-manylinux_2_35_x86_64.whl"], "working_dir":"./", "env_vars":{"RAY_DEDUP_LOGS":"O", "RAY_COLOR_PREFIX":"1"}}' -- \ |
Contributor
There was a problem hiding this comment.
The path to the .wheel here should perhaps be changed.
Also, tabulate, boto3, and duckdb are not required anymore I don't think.
| ray job submit --address='http://localhost:8265' \ | ||
| --runtime-env-json='{"pip":["datafusion", "tabulate", "boto3", "duckdb"], "py_modules":["/home/andy/git/apache/datafusion-ray/target/wheels/datafusion_ray-0.1.0-cp38-abi3-manylinux_2_35_x86_64.whl"], "working_dir":"./", "env_vars":{"RAY_DEDUP_LOGS":"O", "RAY_COLOR_PREFIX":"1"}}' -- \ | ||
| python tpcbench.py \ | ||
| --data /mnt/bigdata/tpch/sf100 \ |
Contributor
There was a problem hiding this comment.
Do you want want to include the k8s resource definition for the ray-storage pvc as well?
Contributor
There was a problem hiding this comment.
I see it is mentioned above that it is assumed. Ok
| [contributor guide]: ../docs/contributing.md | ||
|
|
||
| ```shell | ||
| maturin build --strip |
Contributor
There was a problem hiding this comment.
I would add a comment here reminding users to add --release for a release wheel build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP