-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Notify user if template upgrade is not required #12483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12483 +/- ##
============================================
- Coverage 16.24% 16.23% -0.01%
+ Complexity 13393 13390 -3
============================================
Files 5657 5657
Lines 499107 499108 +1
Branches 60574 60574
============================================
- Hits 81069 81055 -14
- Misses 409001 409014 +13
- Partials 9037 9039 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
sureshanaparti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16465 |
Description
This PR adds a notification in case Router is with latest template version . As of now it shows Upgrade is done, which gives wrong impression if no upgrade is performed.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before:

After:

Log message:

How Has This Been Tested?
How did you try to break this feature and the system with this change?