Skip to content

Conversation

@JeevanYewale
Copy link

Fixes #12466

Problem

The keyword parameter in the listBackupOfferings API was not filtering results. Regardless of the search term provided, the API returned empty results even when matching offerings existed.

Root Cause

The SearchBuilder was using SearchCriteria.Op.EQ instead of SearchCriteria.Op.LIKE for the name field, preventing wildcard matching.

Solution

  • Changed SearchBuilder operation from EQ to LIKE for the name field
  • Enables proper wildcard matching with % symbols for keyword search

Testing

  • Verified that list backupofferings keyword=test now returns matching results
  • Confirmed backward compatibility with existing functionality

Impact

  • Fixes broken keyword search functionality
  • Minimal change with maximum impact (1 line changed)

Signed-off-by: Jeevan Yewale <jeevanyewale4@gmial.com>
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 21, 2026

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.84%. Comparing base (04b58ac) to head (74b0afc).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12480      +/-   ##
============================================
- Coverage     17.84%   17.84%   -0.01%     
+ Complexity    15983    15979       -4     
============================================
  Files          5929     5929              
  Lines        531084   531084              
  Branches      64914    64914              
============================================
- Hits          94795    94785      -10     
- Misses       425675   425685      +10     
  Partials      10614    10614              
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.94% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16459

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

listBackupOfferings API: keyword parameter does not filter results

4 participants