[CELEBORN-2241] Memory swap instead of memory copy#3572
Open
mcdull-zhang wants to merge 2 commits intoapache:mainfrom
Open
[CELEBORN-2241] Memory swap instead of memory copy#3572mcdull-zhang wants to merge 2 commits intoapache:mainfrom
mcdull-zhang wants to merge 2 commits intoapache:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3572 +/- ##
==========================================
+ Coverage 67.05% 67.21% +0.17%
==========================================
Files 357 357
Lines 21779 21847 +68
Branches 1930 1938 +8
==========================================
+ Hits 14602 14683 +81
+ Misses 6160 6144 -16
- Partials 1017 1020 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
You mean that the running time dropped from 6000 seconds to 4000 seconds, that's very impressive. |
Contributor
Author
@FMX It is the sum of shuffle write block time for 22 queries, not the end-to-end query duration; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve performance by using memory swapping instead of memory copying.
Optimization results: The table below shows the shuffle write time for TPCH 1TB.
Note: This is the result of multiple optimizations combined;
other optimizations will be submitted as pull requests in the future.
Why are the changes needed?
Improve performance by reducing memory copying.
Does this PR resolve a correctness bug?
NO
Does this PR introduce any user-facing change?
NO
How was this patch tested?
Existing Unit Tests.